Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSoC'22: New CGAL's design to handle basic viewers #6967

Merged
merged 350 commits into from
Apr 10, 2024
Merged

GSoC'22: New CGAL's design to handle basic viewers #6967

merged 350 commits into from
Apr 10, 2024

Conversation

gdamiand
Copy link
Member

@gdamiand gdamiand commented Oct 14, 2022 •
edited by MaelRL
Loading

Fixes #6943
Replace PR #6921

Mostafa Ashraf's GSoC 2022 Submission

Mentor: @gdamiand
GitHub Page: https://github.com/Mostafa-ashraf19
LinkedIn: Mostafa Ashraf

Small feature: https://cgal.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Basic_viewer

TODOs:

@gdamiand

  • Add Custom KeyPressEvent SimpleSurfaceMeshWithSmallFacesViewerQt, draw_surface_mesh_small_faces.h.
  • Continue Documenting the project.
  • Add something to CHANGES.md
  • check branch size (for @sloriot)

Review

File to review:

  • Boolean_set_operations_2 draw_polygon_set_2.h
  • BGL draw_face_graph.h
  • GraphicsView Buffer_for_vao.h
  • GraphicsView Drawing_functor.h
  • GraphicsView Graphic_buffer.h
  • GraphicsView Basic_viewer_qt.h
  • Linear_cell_complex Viewer.h
  • Linear_cell_complex Viewer.cpp
  • Linear_cell_complex typedefs.h
  • Linear_cell_complex draw_linear_cell_complex.h
  • Nef_3 draw_nef_3.h
  • Periodic_2_triangulation_2 draw_periodic_2_triangulation_2.h
  • Point_set_3 draw_point_set_3.h
  • Polygon draw_polygon_2.h
  • Polygon draw_polygon_with_holes_2.h
  • Polyhedron draw_polyhedron.h
  • Straight_skeleton_2 draw_straight_skeleton_2.h
  • Surface_mesh/examples/Surface_mesh/draw_surface_mesh_small_faces.h
  • Surface_mesh draw_surface_mesh.h
  • Surface_mesh_topology/examples/Surface_mesh_topology/draw_facewidth.h
  • Surface_mesh_topology/examples/Surface_mesh_topology/unsew_edgewidth_repeatedly.cpp
  • Surface_mesh_topology draw_face_graph_with_paths.h
  • Triangulation_2 draw_triangulation_2.h
  • draw_constrained_triangulation_2.h
  • Triangulation_3 draw_triangulation_3.h
  • Voronoi_diagram_2 draw_voronoi_diagram_2.h

Ref manual

Document all draw and add_to_graphics_scene functions:

  • ./Triangulation_2/doc/Triangulation_2/CGAL/draw_triangulation_2.h
  • ./Triangulation_2/doc/Triangulation_2/CGAL/draw_constrained_triangulation_2.h
  • ./Surface_mesh_topology/doc/Surface_mesh_topology/CGAL/draw_face_graph_with_paths.h
  • ./Triangulation_3/doc/Triangulation_3/CGAL/draw_triangulation_3.h
  • ./Arrangement_on_surface_2/doc/Arrangement_on_surface_2/CGAL/draw_arrangement_2.h
  • ./Polygon/include/CGAL/draw_polygon_2.h
  • ./Polygon/include/CGAL/draw_polygon_with_holes_2.h
  • ./Polyhedron/doc/Polyhedron/CGAL/draw_polyhedron.h
  • ./Surface_mesh/include/CGAL/draw_surface_mesh.h
  • ./Nef_3/doc/Nef_3/CGAL/draw_nef_3.h
  • ./Periodic_2_triangulation_2/doc/Periodic_2_triangulation_2/CGAL/draw_periodic_2_triangulation_2.h
  • ./Voronoi_diagram_2/doc/Voronoi_diagram_2/CGAL/draw_voronoi_diagram_2.h
  • ./Linear_cell_complex/doc/Linear_cell_complex/CGAL/draw_linear_cell_complex.h
  • ./Point_set_3/include/CGAL/draw_point_set_3.h
  • ./Boolean_set_operations_2/doc/Boolean_set_operations_2/CGAL/draw_polygon_set_2.h

@gdamiand gdamiand mentioned this pull request Oct 14, 2022
Closed
18 tasks
@sloriot
Copy link
Member

sloriot commented Mar 29, 2024

Errors in arrangement in CGAL-6.0-Ic-205

@sloriot sloriot added Batch_1 First Batch of PRs under testing Tested and removed Under Testing labels Apr 1, 2024
@sloriot
Copy link
Member

sloriot commented Apr 4, 2024

Successfully tested in CGAL-6.0-Ic-209

@sloriot sloriot removed the Batch_1 First Batch of PRs under testing label Apr 4, 2024
@github-actions github-actions bot removed the Tested label Apr 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

This pull-request was previously marked with the label Tested, but has been modified with new commits. That label has been removed.

@sloriot sloriot force-pushed the gsoc2022-EBVs-Mostafa-ashraf19 branch from 884f71c to cb8e880 Compare April 4, 2024 13:41
@sloriot
Copy link
Member

sloriot commented Apr 10, 2024

Successfully tested in CGAL-6.0-Ic-21[56]

@lrineau lrineau self-assigned this Apr 10, 2024
@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Apr 10, 2024
@lrineau lrineau merged commit 4db6bc6 into CGAL:master Apr 10, 2024
9 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Apr 10, 2024
@lrineau lrineau deleted the gsoc2022-EBVs-Mostafa-ashraf19 branch April 10, 2024 17:49
@MaelRL
Copy link
Member

MaelRL commented Apr 10, 2024

@gdamiand Given the new package and how public the basic viewer is now, maybe it is time for a cgal.org news entry to showcase it? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afabri afabri afabri left review comments

@sloriot sloriot sloriot left review comments

@lrineau lrineau lrineau approved these changes

Assignees

@lrineau lrineau

Labels
Accepted small feature gsoc gsoc-2022 Merged_in_6.0 Tested
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging this pull request may close these issues.

GSoC22: New CGAL's design to handle viewers
6 participants
@gdamiand @Mostafa-ashraf19 @afabri @lrineau @sloriot @MaelRL